Send Target.detachedFromTarget event on detach#1929
Merged
krichprollsch merged 1 commit intolightpanda-io:mainfrom Mar 20, 2026
Merged
Send Target.detachedFromTarget event on detach#1929krichprollsch merged 1 commit intolightpanda-io:mainfrom
krichprollsch merged 1 commit intolightpanda-io:mainfrom
Conversation
detachFromTarget and setAutoAttach(false) both null bc.session_id without notifying the client. Per the CDP spec, detaching a session must fire a Target.detachedFromTarget event so the driver stops sending messages on the stale session ID. Capture the session_id before nulling it and fire the event in both code paths. Add tests covering the event emission and the no-session edge case. Fixes lightpanda-io#1819 This contribution was developed with AI assistance (Claude Code + Codex). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
krichprollsch
approved these changes
Mar 20, 2026
Member
|
Thanks for your contribution 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detachFromTargetandsetAutoAttach(autoAttach: false)both nullbc.session_idwithout notifying the client. Per the CDP spec, detaching a session must fire aTarget.detachedFromTargetevent so the driver stops sending messages on the stale session ID.// TODO should we send a Target.detachedFromTarget event?Changes
detachFromTarget: emitTarget.detachedFromTargetwith the session ID before nulling itsetAutoAttach(false): same treatmentdetachFromTargetemits the event after attachdetachFromTargetwithout a session does not emit an eventsetAutoAttach(false)emits the event after attachTest plan
zig build test)Fixes #1819
This contribution was developed with AI assistance (Claude Code + Codex).