Skip to content

fix: update skills for core/ removal, new subsystems, and provider routers#15

Merged
slin1237 merged 1 commit into
mainfrom
fix/skills-systemic-update
Jun 8, 2026
Merged

fix: update skills for core/ removal, new subsystems, and provider routers#15
slin1237 merged 1 commit into
mainfrom
fix/skills-systemic-update

Conversation

@slin1237

@slin1237 slin1237 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Problem

The smg-dev-guide skills had drifted from the smg codebase. A full audit (all skill files vs. smg@a18d64f5) found:

  • model_gateway/src/core/ was removed upstream, leaving dead paths (core/routing/, core/steps/worker/local/) in the map, contribute, review-pr, and three recipes.
  • Subsystems built since the guide was written had zero coverage: priority scheduler, multi-tenancy, rate limiting, memory, and the Anthropic/Gemini provider routers.
  • New components missing from the map: crates skills and blob_storage, the tui dashboard, clients/{python,java,openapi-gen} + the make generate-clients pipeline.
  • Wrong counts/types: reasoning "10+ families" (actually 8), grpc_client/data_connector key types.

Solution

Systemic fixes to the always-loaded skills (map, implement, contribute, review-pr, anti-patterns) plus the dead-path renames in affected recipes. The 10 recipes that need full body rewrites are deferred but now tracked — with the key correction for each — in a new Recipe Freshness table in implement/SKILL.md.

Changes

  • skills/map/SKILL.md: add crates skills + blob_storage, tui, clients/{python,java,openapi-gen}; new "Subsystems Inside model_gateway" section (scheduler, multi-tenancy, rate limiting, memory, provider routers, worker lifecycle); Anthropic/Gemini in request flow; fix key types + counts; add make generate-clients
  • skills/implement/SKILL.md: "Subsystems without a dedicated recipe yet" + "Recipe Freshness" tables
  • skills/contribute/SKILL.md, skills/review-pr/SKILL.md, skills/review-pr/anti-patterns.md: core/ path renames, new subsystem rows, circuit_breaker_can_execute()
  • skills/implement/{routing-policy,grpc-backend,discovery-feature}.md: dead core/ path fixes
  • README.md: recipe counts aligned with the map

Affected Skills

  • smg:map
  • smg:contribute
  • smg:review-pr
  • smg:implement
  • Recipe files (routing-policy, grpc-backend, discovery-feature)
  • Command router (smg.md)
  • Plugin config (plugin.json)

Checklist

  • Follows conventional commit title format
  • Commit(s) are signed off (git commit -s)
  • Tested with claude plugins add . locally
  • Skill triggers correctly on intended prompts
  • No broken @file.md references in skills

Note: this is a content refresh verified by auditing every path/type/count against the smg source tree (not runtime-tested), so the "tested locally / skill triggers" boxes are left unchecked. The 10 major recipe bodies (flagged in the new Recipe Freshness table) still need full rewrites in a follow-up.

…uters

The model_gateway/src/core/ directory was removed upstream (routing moved
to policies/, worker creation to worker/ + workflow/steps/local/), and
several major subsystems were added that the dev guide did not cover.

What changed:
- skills/map/SKILL.md: add crates skills + blob_storage, the tui
  dashboard, and clients/{python,java,openapi-gen}; new "Subsystems
  Inside model_gateway" section (priority scheduler, multi-tenancy, rate
  limiting, memory, provider routers, worker lifecycle); add Anthropic/
  Gemini to the request flow; fix key types (grpc_client, data_connector,
  multimodal); correct counts (reasoning 8 families, tool 14); reframe
  the worker lifecycle as the workflow/steps/local DAG; add
  make generate-clients
- skills/implement/SKILL.md: add a "Subsystems without a dedicated recipe
  yet" table and a "Recipe Freshness" table that flags every recipe whose
  body still needs rewriting, with the key correction for each
- skills/contribute/SKILL.md, review-pr/SKILL.md, anti-patterns.md:
  replace removed core/routing and core/steps/worker/local paths with
  policies/ and worker/ + workflow/steps/local/; add scheduler / tenant /
  rate-limit / provider rows; fix circuit_breaker_can_execute()
- skills/implement/{routing-policy,grpc-backend,discovery-feature}.md:
  fix dead core/ paths (and the circuit-breaker call in the routing
  template)
- README.md: align recipe counts with the map

Why: upstream smg restructured model_gateway and added the priority
scheduler, multi-tenancy, rate limiting, memory, and Anthropic/Gemini
provider routers, leaving the guide with dead paths, wrong counts/types,
and missing subsystems. This pass fixes the always-loaded skills; the 10
major recipe bodies still need full rewrites and are tracked in the new
Recipe Freshness table.

Verified against smg@a18d64f5.

Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
@slin1237 slin1237 merged commit 5e0264c into main Jun 8, 2026
2 checks passed
@slin1237 slin1237 deleted the fix/skills-systemic-update branch June 8, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant