fix: update skills for core/ removal, new subsystems, and provider routers#15
Merged
Conversation
…uters
The model_gateway/src/core/ directory was removed upstream (routing moved
to policies/, worker creation to worker/ + workflow/steps/local/), and
several major subsystems were added that the dev guide did not cover.
What changed:
- skills/map/SKILL.md: add crates skills + blob_storage, the tui
dashboard, and clients/{python,java,openapi-gen}; new "Subsystems
Inside model_gateway" section (priority scheduler, multi-tenancy, rate
limiting, memory, provider routers, worker lifecycle); add Anthropic/
Gemini to the request flow; fix key types (grpc_client, data_connector,
multimodal); correct counts (reasoning 8 families, tool 14); reframe
the worker lifecycle as the workflow/steps/local DAG; add
make generate-clients
- skills/implement/SKILL.md: add a "Subsystems without a dedicated recipe
yet" table and a "Recipe Freshness" table that flags every recipe whose
body still needs rewriting, with the key correction for each
- skills/contribute/SKILL.md, review-pr/SKILL.md, anti-patterns.md:
replace removed core/routing and core/steps/worker/local paths with
policies/ and worker/ + workflow/steps/local/; add scheduler / tenant /
rate-limit / provider rows; fix circuit_breaker_can_execute()
- skills/implement/{routing-policy,grpc-backend,discovery-feature}.md:
fix dead core/ paths (and the circuit-breaker call in the routing
template)
- README.md: align recipe counts with the map
Why: upstream smg restructured model_gateway and added the priority
scheduler, multi-tenancy, rate limiting, memory, and Anthropic/Gemini
provider routers, leaving the guide with dead paths, wrong counts/types,
and missing subsystems. This pass fixes the always-loaded skills; the 10
major recipe bodies still need full rewrites and are tracked in the new
Recipe Freshness table.
Verified against smg@a18d64f5.
Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
smg-dev-guideskills had drifted from thesmgcodebase. A full audit (all skill files vs.smg@a18d64f5) found:model_gateway/src/core/was removed upstream, leaving dead paths (core/routing/,core/steps/worker/local/) in the map, contribute, review-pr, and three recipes.skillsandblob_storage, thetuidashboard,clients/{python,java,openapi-gen}+ themake generate-clientspipeline.grpc_client/data_connectorkey types.Solution
Systemic fixes to the always-loaded skills (map, implement, contribute, review-pr, anti-patterns) plus the dead-path renames in affected recipes. The 10 recipes that need full body rewrites are deferred but now tracked — with the key correction for each — in a new Recipe Freshness table in
implement/SKILL.md.Changes
skills/map/SKILL.md: add cratesskills+blob_storage,tui,clients/{python,java,openapi-gen}; new "Subsystems Insidemodel_gateway" section (scheduler, multi-tenancy, rate limiting, memory, provider routers, worker lifecycle); Anthropic/Gemini in request flow; fix key types + counts; addmake generate-clientsskills/implement/SKILL.md: "Subsystems without a dedicated recipe yet" + "Recipe Freshness" tablesskills/contribute/SKILL.md,skills/review-pr/SKILL.md,skills/review-pr/anti-patterns.md:core/path renames, new subsystem rows,circuit_breaker_can_execute()skills/implement/{routing-policy,grpc-backend,discovery-feature}.md: deadcore/path fixesREADME.md: recipe counts aligned with the mapAffected Skills
smg:mapsmg:contributesmg:review-prsmg:implementrouting-policy,grpc-backend,discovery-feature)smg.md)plugin.json)Checklist
git commit -s)claude plugins add .locally@file.mdreferences in skills