fix(runtime): restore EnvField overrides after exceptions#601
Draft
Xiangyi1996 wants to merge 1 commit into
Draft
fix(runtime): restore EnvField overrides after exceptions#601Xiangyi1996 wants to merge 1 commit into
Xiangyi1996 wants to merge 1 commit into
Conversation
Signed-off-by: Xiangyi Zhang <xiangyiz@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnvFieldoverride from afinallyblockNonestateWhy
EnvField.override()previously restored its saved state only after the context manager body returned normally. If the body raised, execution skipped the restoration code and leaked the temporary environment value into later work.This is particularly misleading in tests: one expected assertion failure can change backend configuration for subsequent tests and produce unrelated cascading failures. The same issue affects callers that use scoped runtime overrides.
Behavior
The normal-path behavior is unchanged. On both normal return and exception, the context manager now restores:
NonemarkerValidation
pre-commit run --all-files: passedpytest -q test/runtime/test_env.py: 3 passedThis PR is independent of #600 and targets
maindirectly.