Skip to content

refactor: rsync and scp into copytool pkg#4521

Draft
unsuman wants to merge 2 commits intolima-vm:masterfrom
unsuman:refactor/rsync
Draft

refactor: rsync and scp into copytool pkg#4521
unsuman wants to merge 2 commits intolima-vm:masterfrom
unsuman:refactor/rsync

Conversation

@unsuman
Copy link
Contributor

@unsuman unsuman commented Jan 12, 2026

Yes, I think we should make a separate package rsync same as https://github.com/AkihiroSuda/alcless/blob/master/pkg/rsync/rsync.go
but this can be done by me in another PR?

Originally posted by @unsuman in #4429 (comment)

Depends on #4429

@unsuman
Copy link
Contributor Author

unsuman commented Jan 12, 2026

Left with the refactoring of rsync in the cmd/limactl/shell.go file with these current changes.
Since there exists bats testing for the copy and shell --sync command, is there a need to add unit tests for this new copytool package?

…g the host files

Signed-off-by: Ansuman Sahoo <anshumansahoo500@gmail.com>
Signed-off-by: Ansuman Sahoo <anshumansahoo500@gmail.com>
@AkihiroSuda
Copy link
Member

Needs rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants