fix: LIMA_SHELLENV_ALLOW doesn't remove variables#4827
Closed
mikerhodes wants to merge 1 commit into
Closed
Conversation
When LIMA_SHELLENV_ALLOW was set, limactl shell --preserve-env didn't remove environment variables not on the list specified by LIMA_SHELLENV_ALLOW. This didn't match the documented behavior. This commit updates the code to filter out all variables not on the allowlist, if the allowlist is configured. Fix the associated test to match the expected behavior. Fixes lima-vm#4826. Signed-off-by: Mike Rhodes <mike.rhodes@gmail.com>
jandubois
requested changes
Apr 11, 2026
Member
jandubois
left a comment
jandubois
left a comment
There was a problem hiding this comment.
As I've commented in #4826 (comment), it is unfortunately the documentation, that is out-of-date, and not the code.
We should change the documentation to match the intent of the feature.
Sorry for wasting your time on the code change! 😞
Author
|
Ach, no problem! Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
LIMA_SHELLENV_ALLOWwas set,limactl shell --preserve-envdidn't remove environment variables that were not on the list specified byLIMA_SHELLENV_ALLOW. This didn't match the documented behavior.This commit updates the code to filter out all variables not on the allowlist, if the allowlist is configured.
Fix the associated test to match the expected behavior.
Fixes #4826.