Skip to content

feat:add virtio-sound interface#5016

Open
Aneesh-Hegde wants to merge 1 commit into
lima-vm:masterfrom
Aneesh-Hegde:add-audio
Open

feat:add virtio-sound interface#5016
Aneesh-Hegde wants to merge 1 commit into
lima-vm:masterfrom
Aneesh-Hegde:add-audio

Conversation

@Aneesh-Hegde
Copy link
Copy Markdown
Contributor

#3730

Local Test result:
OS: Arch Linux

$ ./_output/bin/limactl start --name=test-virtio --audio-interface=virtio --audio-device=none template:default
$ ./_output/bin/limactl shell test-virtio sudo lspci | grep -i audio
00:05.0 Multimedia audio controller: Red Hat, Inc. Virtio 1.0 sound (rev 01)
$ ./_output/bin/limactl start --name=test-hda --audio-interface=hda template:default
$ ./_output/bin/limactl shell test-hda sudo lspci | grep -i audio
00:05.0 Audio device: Intel Corporation 82801I (ICH9 Family) HD Audio Controller (rev 03)

Note on Cross-Platform Testing (macOS & Windows):
Due to host OS limitations, I am unable to test the macOS and Windows specific drivers locally.

@Aneesh-Hegde Aneesh-Hegde force-pushed the add-audio branch 3 times, most recently from 513b535 to 3a8fd80 Compare May 20, 2026 13:53
@Aneesh-Hegde
Copy link
Copy Markdown
Contributor Author

Aneesh-Hegde commented May 21, 2026

Hey @jandubois can you PTAL whenever you have time. Thanks:)

@Aneesh-Hegde
Copy link
Copy Markdown
Contributor Author

Hey @afbjorklund gentle ping for review

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Jun 2, 2026

  Error: pkg/driver/external/client/client.go:35:2: directive `//nolint:staticcheck // grpc.Dial is used for compatibility reasons` is unused for linter "staticcheck" (nolintlint)
  	//nolint:staticcheck // grpc.Dial is used for compatibility reasons
  	^
  Error: pkg/guestagent/api/client/credentials.go:47:2: directive `//nolint:staticcheck // c.info.ServerName is used for compatibility reason` is unused for linter "staticcheck" (nolintlint)
  	//nolint:staticcheck // c.info.ServerName is used for compatibility reason
  	^
  Error: pkg/driver/qemu/qemu.go:376:2: SA4023(related information): the lhs of the comparison is the 2nd return value of this function call (staticcheck)
  	macOSProductVersion, err := osutil.ProductVersion()
  	^
  Error: pkg/driver/qemu/qemu.go:377:5: SA4023: this comparison is always true (staticcheck)
  	if err != nil {
  	   ^
  Error: pkg/driver/qemu/qemu_driver.go:452:2: SA4023(related information): the lhs of the comparison is the 2nd return value of this function call (staticcheck)
  	macOSProductVersion, err := osutil.ProductVersion()
  	^
  Error: pkg/driver/qemu/qemu_driver.go:453:5: SA4023: this comparison is always true (staticcheck)
  	if err != nil {
  	   ^
  6 issues:
  * nolintlint: 2
  * staticcheck: 4

https://github.com/lima-vm/lima/actions/runs/26167141422/job/76974336024?pr=5016

@Aneesh-Hegde
Copy link
Copy Markdown
Contributor Author

  Error: pkg/driver/external/client/client.go:35:2: directive `//nolint:staticcheck // grpc.Dial is used for compatibility reasons` is unused for linter "staticcheck" (nolintlint)
  	//nolint:staticcheck // grpc.Dial is used for compatibility reasons
  	^
  Error: pkg/guestagent/api/client/credentials.go:47:2: directive `//nolint:staticcheck // c.info.ServerName is used for compatibility reason` is unused for linter "staticcheck" (nolintlint)
  	//nolint:staticcheck // c.info.ServerName is used for compatibility reason
  	^
  Error: pkg/driver/qemu/qemu.go:376:2: SA4023(related information): the lhs of the comparison is the 2nd return value of this function call (staticcheck)
  	macOSProductVersion, err := osutil.ProductVersion()
  	^
  Error: pkg/driver/qemu/qemu.go:377:5: SA4023: this comparison is always true (staticcheck)
  	if err != nil {
  	   ^
  Error: pkg/driver/qemu/qemu_driver.go:452:2: SA4023(related information): the lhs of the comparison is the 2nd return value of this function call (staticcheck)
  	macOSProductVersion, err := osutil.ProductVersion()
  	^
  Error: pkg/driver/qemu/qemu_driver.go:453:5: SA4023: this comparison is always true (staticcheck)
  	if err != nil {
  	   ^
  6 issues:
  * nolintlint: 2
  * staticcheck: 4

https://github.com/lima-vm/lima/actions/runs/26167141422/job/76974336024?pr=5016

Done

Signed-off-by: Aneesh-Hegde <aneeshhegde7110@gmail.com>
@Aneesh-Hegde
Copy link
Copy Markdown
Contributor Author

@afbjorklund PTAL:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants