Skip to content

qemu: use stream netdev with reconnect for socketVMNet networking #5027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loncharles wants to merge 1 commit into
base: master
Choose a base branch
from
Open

qemu: use stream netdev with reconnect for socketVMNet networking #5027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions pkg/driver/qemu/qemu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,9 +816,17 @@ func Cmdline(ctx context.Context, cfg Config) (exe string, args []string, err er
if err != nil {
return "", nil, err
}
args = append(args, "-netdev", fmt.Sprintf("socket,id=net%d,fd={{ fd_connect %q }}", i+1, sock))
// TODO: should we also validate that the socket exists, or do we rely on the
// networks reconciler to throw an error when the network cannot start?
if strings.Contains(string(features.NetdevHelp), "stream") {
netdev := fmt.Sprintf("stream,id=net%d,server=off,addr.type=unix,addr.path=%s", i+1, sock)
if !version.LessThan(*semver.New("9.2.0")) {
netdev += ",reconnect-ms=500"
} else if !version.LessThan(*semver.New("8.0.0")) {
netdev += ",reconnect=1"
}
args = append(args, "-netdev", netdev)
} else {
args = append(args, "-netdev", fmt.Sprintf("socket,id=net%d,fd={{ fd_connect %q }}", i+1, sock))
}
}
} else if nw.Socket != "" {
args = append(args, "-netdev", fmt.Sprintf("socket,id=net%d,fd={{ fd_connect %q }}", i+1, nw.Socket))
Expand Down
Loading