fix: disable user containerd by default for non-Linux guests#5065
Closed
RoySerbi wants to merge 1 commit into
Closed
fix: disable user containerd by default for non-Linux guests#5065RoySerbi wants to merge 1 commit into
RoySerbi wants to merge 1 commit into
Conversation
Member
|
Duplicate: Also missing DCO sign |
Author
|
Thanks @AkihiroSuda — closing as duplicate of #5041. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5037.
containerd.userwas defaulted from the guest architecture only, so macOS guests onx86_64oraarch64enabled user containerd and pulled the nerdctl archive even though containerd/nerdctl are Linux guest functionality.This keeps the existing default for Linux guests on
x86_64andaarch64, but defaultscontainerd.usertofalsefor non-Linux guests.I also added a small table test for the defaulting behavior across Linux and Darwin guests.
Local check:
git diff --checkI could not run
go testlocally because this Windows environment does not have the Go toolchain installed.