limactl edit: support editing a running instance#5072
Draft
itsme-ranger wants to merge 1 commit into
Draft
Conversation
Previously `limactl edit` returned an error when the instance was running. - Interactive (tty, no --set): prompt the user to stop the instance first; abort if declined. After editing and validation, prompt to restart as usual. - Non-interactive (--set): validate the new config first so the instance stays running if validation fails. Stop, apply, and restart automatically only after validation succeeds. Fixes: lima-vm#3346 Signed-off-by: Ramadhan Gerry Akbar <ramadhan.gerry@gmail.com>
itsme-ranger
force-pushed
the
fix/edit-running-instance
branch
from
d03bce0 to
cd9db12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Removes the hard error when
limactl editis called on a running instance, replacing it with two sensible behaviours:--set): prompts the user to stop the instance first; aborts if declined. After editing and validation, prompts to restart as usual.--setor similar flags): validates the new config on the current content first so the instance stays running if validation fails. Stops, applies, and restarts automatically only after validation succeeds.Linked Issue
Closes #3346
How I Tested This
Unit tests pass. Integration test requires a running instance — tested the logic manually by reading through the control flow.