restart: accept editflags to modify configuration before restarting#5076
Open
itsme-ranger wants to merge 1 commit into
Open
restart: accept editflags to modify configuration before restarting#5076itsme-ranger wants to merge 1 commit into
itsme-ranger wants to merge 1 commit into
Conversation
Closes lima-vm#4249 Signed-off-by: Ramadhan Gerry Akbar <ramadhan.gerry@gmail.com>
800ae74 to
99a2b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4249
Changes
limactl restartnow accepts all editflags (the same flags available onlimactl edit), so you can atomically edit and restart an instance in one command:Implementation
When any editflag is provided,
restartActionreads the currentlima.yaml, applies the yq expressions, validates the result (same pipeline aslimactl edit), and writes the updated config — all before stopping the instance. This ensures validation errors are caught before any disruptive stop. Then the normal stop+start flow runs viainstance.Restart/instance.RestartForcibly.If no editflags are provided, behavior is identical to before.
Testing
go build ./cmd/limactl/passesgo test ./cmd/limactl/...passesgolangci-lint run ./cmd/limactl/...reports 0 issues