shell: add --sync-exclude flag to exclude paths from --sync#5077
Open
itsme-ranger wants to merge 1 commit into
Open
shell: add --sync-exclude flag to exclude paths from --sync#5077itsme-ranger wants to merge 1 commit into
itsme-ranger wants to merge 1 commit into
Conversation
Closes lima-vm#4887 Signed-off-by: Ramadhan Gerry Akbar <ramadhan.gerry@gmail.com>
7626689 to
f54bc52
Compare
Member
|
Seems duplicate of #4917 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4887
Changes
Adds a
--sync-excludeflag tolimactl shell --syncthat passes--excludeto all rsync operations (host→guest initial sync, the dry-run stats pass, and the guest→host sync-back).The flag uses rsync's standard
--excludesyntax and can be specified multiple times. Using--sync-excludewithout--syncreturns an error.Implementation
--sync-excludeas aStringArrayflag on the shell commandexcludeArgsas["--exclude", val, ...]pairscopytool.Options.AdditionalArgsof the initial sync CopyTool (which is also reused for rsync-back and the "view changes" diff)excludeArgsparameter togetRsyncStatsso the dry-run stats pass applies the same filtersTesting
go build ./cmd/limactl/passesgo test ./cmd/limactl/...passesgolangci-lint run ./cmd/limactl/...reports 0 issues