DO NOT MERGE: hostagent: add a timeout to requirement check attempts - #5383
Draft
jandubois wants to merge 1 commit into
Draft
DO NOT MERGE: hostagent: add a timeout to requirement check attempts#5383jandubois wants to merge 1 commit into
jandubois wants to merge 1 commit into
Conversation
A requirement check gets 200 retries, but each attempt waits on its ssh probe forever, so one connection that never returns blocks startup until limactl's watchdog expires. This happened on a macOS host where security software withheld data from the first ssh connection while a second connection succeeded instantly (rancher-sandbox/rancher-desktop#10761). Kill the probe after 3 seconds and let the loop retry; the connection is local, so a slow probe is a wedged probe. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A requirement check gets 200 retries, but each attempt waits on its ssh probe forever, so one connection that never returns blocks startup until limactl's watchdog expires. This happened on a macOS host where security software withheld data from the first ssh connection while a second connection succeeded instantly (rancher-sandbox/rancher-desktop#10761).
Kill the probe after 3 seconds and let the loop retry; the connection is local, so a slow probe is a wedged probe.
Assisted-by: Fable 5
This should not be merged as-is; part of the change should go into sshocker instead.