wsl2: validate guest-reported address in getSSHAddress - #5405
Open
SABITHSAHEB wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sabith Saheb <shabi7204192361@gmail.com>
Contributor
Author
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hostname -I | cut,ip route get 1 | awk); only the fallback branch checked the output was an IP, the first two returned it verbatim.--, so a compromised guest returning-oProxyCommand=<cmd>has it parsed as an ssh option and run on the host (a plain hostname just points the host's ssh/scp/rsync, which use StrictHostKeyChecking=no, at an endpoint the guest picks).Route all three branches through one helper that returns the value only when it is a routable, non-loopback IP, matching what the fallback already required.