Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant @dependabot write permission for workflow files. #5422

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Jan 29, 2024

Because @dependabot sends pull requests to update the versions of GitHub Actions plugins in workflow files.

Because @dependabot sends pull requests to update the versions of GitHub
Actions plugins in workflow files.
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e64cea1) 73.92% compared to head (f88b7d1) 73.93%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5422   +/-   ##
=========================================
  Coverage     73.92%   73.93%           
- Complexity    20688    20691    +3     
=========================================
  Files          1791     1791           
  Lines         76336    76336           
  Branches       9716     9716           
=========================================
+ Hits          56433    56436    +3     
- Misses        15289    15291    +2     
+ Partials       4614     4609    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇 👍 🙇

@ikhoon ikhoon merged commit a35ffb9 into line:main Jan 30, 2024
16 of 17 checks passed
@ikhoon ikhoon deleted the dependabot-permission-workflow branch January 30, 2024 02:07
@jrhee17
Copy link
Contributor

jrhee17 commented Jan 31, 2024

Question) Has this been reflected in our CI machines also? A fresh PR from today also seemed to have failed: #5429

@ikhoon
Copy link
Contributor Author

ikhoon commented Jan 31, 2024

I updated the script on the CI machines yesterday. Let me take a closer look.

@ikhoon
Copy link
Contributor Author

ikhoon commented Jan 31, 2024

@dependabot[bot] is not a maintainer. Disallowed to change GitHub Actions workflows.

Oops... the name is different. I realized that GitHub appends [bot] suffix to bot accounts. 😅

@ikhoon
Copy link
Contributor Author

ikhoon commented Jan 31, 2024

Created #5431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants