Appearances for MINI #40
Merged
+67
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odanado
reviewed
Jan 10, 2025
|
|
||
| export default function Header() { | ||
| const {filter, appId} = useContext(AppContext); | ||
| const appName = useMemo(() => { | ||
| return filter === 'LIFF' ? 'LIFF Playground' : 'LINE MINI App Playground' |
There was a problem hiding this comment.
I noticed that the style of the Open in LINE button is broken.
Applying the following diff can prevent the button's style from breaking.
diff --git a/src/components/Header.module.css b/src/components/Header.module.css
index 87edea9..02e74ac 100644
--- a/src/components/Header.module.css
+++ b/src/components/Header.module.css
@@ -17,6 +17,14 @@
align-items: center;
}
+.left {
+ flex: 1;
+}
+
+.right {
+ flex-basis: 100px;
+}
+
.left a {
text-decoration: none;
color: #000;
There was a problem hiding this comment.
|
The implementation of the notice switching was missing, so it has been added. e699014 |
odanado
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #37
Summary
In order to provide this as a Playground for MINI, changes were made to allow switching the appearance of text and other items.