bugfix: int32 is converted to incorrect string#416
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 55.19% 55.19%
=======================================
Files 87 87
Lines 5479 5479
=======================================
Hits 3024 3024
Misses 2233 2233
Partials 222 222 ☔ View full report in Codecov by Sentry. |
Yang-33
reviewed
Jan 22, 2024
| "github.com/line/line-bot-sdk-go/v8/linebot/messaging_api" | ||
| ) | ||
|
|
||
| func TestGetFollowers_ItShouldCorrectlyPassLimitQueryParameter(t *testing.T) { |
Contributor
|
This bug was fixed as v8.2.1 , thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
stringifymacro inapi.pebbledoesn't handleint32Go type properly. It directly usesstring(...)to convertint32tostringwhich will generate a UTF-8 character corresponding to the value of int instead. For example,string(57)will result in"9"instead of"57". This bug makesMessagingApiAPI.GetFollowers(start string, limit int32)to be nearly impossible to use.To fix this, this PR changes add another condition to
stringifymacro forIntegertype. With this change, it will usestrconv.FormatInteger(int64(...), 10)instead ofstring(...)which yield a correct string value.Apart from the bugfix, I also refactor
api.pebblea bit to re-usestringifymacro for any place required to usestringtype. And also add another condition tostringifymacro to not doing an unnecessary string-conversion again forstringtype.