Fix a couple of bugs in cargo-sort
#1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
02-06-tomlfmt
branch
2 times, most recently
from
e8d8203 to
0257367
Compare
Twey
changed the title
tomlfmt.toml file with better defaults for cargo-sortcargo-sort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Trailing commas are good :)
This PR previously added a
tomlfmt.tomlthat configured themultiline_trailing_commafeature. Unfortunately, this exposed a bug incargo-sortthat meant it was impossible to format the workspaceCargo.tomlto its liking. Furthermore, on inspection of the documentation, it turns out thatmultiline_trailing_commashould be on by default.I added a PR fixing these bugs, and the test that should have caught them.
Proposal
Point our CI's
cargo sortto my branch.Test Plan
CI
Release Plan
Invisible to users.
Links