Simplify config loading #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jogrogan
reviewed
Feb 10, 2025
Comment on lines
38
to
+39
| properties.putAll(ConnectStringParser.parse(url.substring(getConnectStringPrefix().length()))); | ||
| properties.putAll(props); // in case the driver is loaded via getConnection() |
There was a problem hiding this comment.
Should these lines be reversed? Trying to think if there are config collisions, which should take precedence. I'd think the connection properties should (same as you have for HoptimatorDriver)
There was a problem hiding this comment.
The JDBC spec says the precedence order is undefined and driver specific! So whatever makes sense to us I guess. Agree that the URL should take precedence, since that is more likely to be what end users are actually able to manipulate. Will fix, thx.
jogrogan
reviewed
Feb 10, 2025
Comment on lines
42
to
+43
| properties.putAll(ConnectStringParser.parse(url.substring(getConnectStringPrefix().length()))); | ||
| properties.putAll(props); // in case the driver is loaded via getConnection() |
jogrogan
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ConfigService. Instead, rely on connection properties.catalogsconnection property to limit loaded catalogs.getConnection()argument.Details
Previously,
ConfigServicewas used within various plugins (e.g. JDBC drivers) to load dynamic configuration. Some of these cases are now obviated by #99's connection properties, which thread through to each plugin, except JDBC drivers. For JDBC drivers, we prefer to use their respective URL, when possible, since relying onConfigServicemay involve dynamically fetching configurations (e.g. ConfigMaps) when loading each database.In addition, we will want to support a
CREATE DATABASEeventually, which won't be able to provide the out-of-band configuration thatConfigServiceneeds. For example, we can havecreate database foo.bar location 'jdbc:foo://cluster=bar;fabric=prod', which fully specifies the external connection. We don't need to additionally supply a configmap out-of-band.Testing
Verified manually with client.