Change config loading order to give URLs precedence #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change config loading order in JDBC drivers to consistently give URL properties precedence over
getConnection()
's properties.Details
JDBC drivers may be loaded via the older
DriverManager
mechanism or via the newerDataSource
mechanism. With the former, drivers may be loaded asgetConnection(url, props)
, whereprops
are optional connection properties. The URL itself very often includes connection properties, raising the question of which source of properties takes precdence.The JDBC docs do not specify what should happen here, explicitly leaving it to the drivers to decide.
Given that end users can often only control and see the URL, we think it makes sense to given the URL precedence here. In that case, the
props
supplied togetConnection()
should be considered defaults rather than overrides.The opposite approach would yield surprising behavior, when e.g. a log showed
jdbc:foo://bar=qux
while the driver silently overwrotebar
.Testing
None. Integration tests should cover this trivial change.