(feat) Add deleteMany Dao method #496
Conversation
| // entire delete operation should be atomic | ||
| runInTransactionWithRetry(() -> { | ||
| aspectClasses.forEach(x -> delete(urn, x, auditStamp, maxTransactionRetry, trackingContext)); | ||
| return null; | ||
| }, maxTransactionRetry); |
There was a problem hiding this comment.
Open Question 1
This implementation propagates maxTransactionRetry to the individual deletion level.
Alternatively, the "maxTransactionRetry" can be only a top-level retry setting that only applies to the overall transaction and NOT the individuals.
| @Nonnull AuditStamp auditStamp, | ||
| int maxTransactionRetry, | ||
| @Nullable IngestionTrackingContext trackingContext) { | ||
| // entire delete operation should be atomic |
There was a problem hiding this comment.
This was decided in the Spec Design Review as a comment from Yang.
| @@ -811,6 +811,61 @@ public <ASPECT extends RecordTemplate> ASPECT add(@Nonnull URN urn, AspectUpdate | |||
| : unwrapAddResult(urn, result, auditStamp, trackingContext)); | |||
| } | |||
|
|
|||
| /** | |||
| * Deletes the latest version of aspects for an entity. Aspects must be a supported aspect types in {@code ASPECT_UNION} | |||
There was a problem hiding this comment.
Validating whether an Aspect is deletable will be done "above" the datahub-gma level. This is decided here: https://docs.google.com/document/d/1aYq106Um6B3_AUKdR4QtowANO27C2GlChROdZj4vdlw/edit?disco=AAABcVgHQSg
| * @param maxTransactionRetry maximum number of transaction retries before throwing an exception | ||
| */ | ||
| public void deleteMany(@Nonnull URN urn, | ||
| @Nonnull Set<Class<? extends RecordTemplate>> aspectClasses, |
There was a problem hiding this comment.
Open Question 2
Use a Set as input to handle the case of duplicate Aspect classes for deletion.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
============================================
- Coverage 66.16% 66.05% -0.12%
Complexity 1536 1536
============================================
Files 137 137
Lines 5917 5927 +10
Branches 656 656
============================================
Hits 3915 3915
- Misses 1723 1733 +10
Partials 279 279 ☔ View full report in Codecov by Sentry. |
Summary
In order to support the new Delete Aspect API, a
deleteMany()method (with default-parameter variants) was added.DeleteMany will be used to support the following spec:
Testing Done
Adjusted additional unit testing and added a new one.
Checklist