Skip to content

Commit

Permalink
add requestbasedmetarepository integration testing
Browse files Browse the repository at this point in the history
  • Loading branch information
pthirun committed Feb 7, 2025
1 parent 1a28131 commit 70236be
Showing 1 changed file with 10 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,15 @@ public void testThinClientMetaStoreBasedRepository() throws InterruptedException
}
}

// TODO PRANAV move this test and use the full DVC
// Can we add a new test file where we run a more
// comprehensive integration test with a DVC? i.e
// push some new versions or make some store config
// changes and make sure the DVC pick up those changes.
// You can see examples like the recently added
// testBatchOnlyMaterializedViewDVCConsumer.
// You probably don't need a VeniceTwoLayerMultiRegionMultiClusterWrapper,
// a single region will be sufficient.
@Test(timeOut = 120 * Time.MS_PER_SECOND)
public void testRequestBasedMetaStoreBasedRepository() throws InterruptedException {
String regularVeniceStoreName = Utils.getUniqueString("venice_store");
Expand All @@ -306,8 +315,7 @@ public void testRequestBasedMetaStoreBasedRepository() throws InterruptedExcepti
.build();
nativeMetadataRepository = NativeMetadataRepository.getInstance(clientConfig, backendConfig);
nativeMetadataRepository.start();
// ThinClientMetaStoreBasedRepository implementation should be used since CLIENT_USE_META_SYSTEM_STORE_REPOSITORY
// is set to true without enabling other feature flags.
// RequestBasedMetaRepository implementation should be used since
Assert.assertTrue(nativeMetadataRepository instanceof RequestBasedMetaRepository);
verifyRepository(nativeMetadataRepository, regularVeniceStoreName);
} finally {
Expand Down

0 comments on commit 70236be

Please sign in to comment.