[da-vinc-client] DVC aggregates push status updates across partitions #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mynameborat
reviewed
Jul 11, 2024
clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java
Outdated
Show resolved
Hide resolved
gaojieliu
reviewed
Jul 11, 2024
clients/da-vinci-client/src/main/java/com/linkedin/davinci/config/VeniceServerConfig.java
Outdated
Show resolved
Hide resolved
huangminchn
force-pushed
the
dvc_write_batch_push_status_update
branch
3 times, most recently
from
c441560 to
81b91fe
Compare
gaojieliu
reviewed
Aug 5, 2024
...da-vinci-client/src/main/java/com/linkedin/davinci/notifier/PushStatusDelayedUpdateTask.java
Outdated
Show resolved
Hide resolved
...da-vinci-client/src/main/java/com/linkedin/davinci/notifier/PushStatusDelayedUpdateTask.java
Outdated
Show resolved
Hide resolved
...da-vinci-client/src/main/java/com/linkedin/davinci/notifier/PushStatusDelayedUpdateTask.java
Outdated
Show resolved
Hide resolved
huangminchn
force-pushed
the
dvc_write_batch_push_status_update
branch
from
81b91fe to
1a1acf5
Compare
gaojieliu
reviewed
Aug 8, 2024
clients/da-vinci-client/src/main/java/com/linkedin/davinci/VersionBackend.java
Outdated
Show resolved
Hide resolved
...da-vinci-client/src/main/java/com/linkedin/davinci/notifier/DaVinciPushStatusUpdateTask.java
Show resolved
Hide resolved
gaojieliu
reviewed
Aug 8, 2024
clients/da-vinci-client/src/main/java/com/linkedin/davinci/VersionBackend.java
Outdated
Show resolved
Hide resolved
huangminchn
force-pushed
the
dvc_write_batch_push_status_update
branch
from
17c04ef to
acc4b86
Compare
huangminchn
force-pushed
the
dvc_write_batch_push_status_update
branch
from
acc4b86 to
476ced1
Compare
gaojieliu
reviewed
Aug 30, 2024
...da-vinci-client/src/main/java/com/linkedin/davinci/notifier/DaVinciPushStatusUpdateTask.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the DVC to write batching push status updates across all partitions on a node.
During batch pushes, one DVC instance will send two events to the push statuses updates to
push status system stores:
one event indicating the push has started in this DVC node;
and another event indicating that the push has completed in all partitions assigned to this DVC node so far.
A config to control this behavior:
write.batching.push.status - by default, it's disabled. Will update default value after enough testing.
The batching only applies to batch push part, it doesn't affect incremental pushes so far.
How was this PR tested?
Added integration tests.
Does this PR introduce any user-facing changes?