[controller] Checking parent controller region state before handling requests for all routes #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonytoni
changed the title
internal/venice-common/src/main/java/com/linkedin/venice/ParentControllerState.java
Outdated
Show resolved
Hide resolved
services/venice-controller/src/main/java/com/linkedin/venice/controller/Admin.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/ParentControllerState.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/linkedin/venice/controller/server/VeniceParentControllerStateHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/linkedin/venice/controller/server/VeniceParentControllerStateHandler.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/ConfigKeys.java
Outdated
Show resolved
Hide resolved
...e-controller/src/main/java/com/linkedin/venice/controller/VeniceControllerClusterConfig.java
Outdated
Show resolved
Hide resolved
bonytoni
force-pushed
the
RegionStatesHandleRequests
branch
from
bac4d5e to
5c3f6a3
Compare
bonytoni
changed the title
nisargthakkar
previously approved these changes
Jul 29, 2024
...integrationTest/java/com/linkedin/venice/controller/server/TestBackupControllerResponse.java
Outdated
Show resolved
Hide resolved
…ParentControllerRegionStateHandler
…h VeniceParentControllerRegionStateHandler" This reverts commit 1c03f5b.
- Added ACTIVE checks to all routes in AdminSparkServer using VeniceParentControllerRegionStateHandler wrapper class - Reverted CreateVersionTest to previous commit without ParentControllerRegionState.ACTIVE - Removed some minor parentheses in ParentControllerRegionState
bonytoni
force-pushed
the
RegionStatesHandleRequests
branch
from
8e492e1 to
df3f9b9
Compare
...mon/src/integrationTest/java/com/linkedin/venice/controller/server/TestAdminSparkServer.java
Outdated
Show resolved
Hide resolved
…t ParentControllerRegionState.ACTIVE
nisargthakkar
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking parent controller region state before handling requests for all routes
ParentControllerRegionStateACTIVE- parent controller serves requestsPASSIVE- parent controller rejects requestsVeniceParentControllerRegionStateHandleris a wrapper class forRoutethat checks the state of the region of the parent controller before handling requests. This class was used inAdminSparkServerto wrap routes in:AdminCommandExecutionRoutesAdminTopicMetadataRoutesClusterDiscoveryClusterRoutesControllerRoutesCreateStoreCreateVersionDataRecoveryRoutesJobRoutesMigrationRoutesNewClusterBuildOutRoutesNodesAndReplicasRoutersClusterConfigRoutesSchemaRoutesSkipAdminRouteStoragePersonaRoutesStoresRoutesVersionRouteCONTROLLER_PARENT_REGION_STATEinConfigKeysto retrieve the config value from the backendNext steps: Implement the parent controller region state config in the backend
How was this PR tested?
Unit Tests, Integration Tests
Does this PR introduce any user-facing changes?