[server] Add request based store properties endpoint to server #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem store for forward compatibility support
pthirun
force-pushed
the
main
branch
3 times, most recently
from
15d22e6 to
3b2064f
Compare
xunyin8
reviewed
Dec 10, 2024
...src/integrationTest/java/com/linkedin/venice/endToEnd/TestServerStorePropertiesEndpoint.java
Outdated
Show resolved
Hide resolved
...src/integrationTest/java/com/linkedin/venice/endToEnd/TestServerStorePropertiesEndpoint.java
Outdated
Show resolved
Hide resolved
...src/integrationTest/java/com/linkedin/venice/endToEnd/TestServerStorePropertiesEndpoint.java
Show resolved
Hide resolved
...s/venice-server/src/main/java/com/linkedin/venice/listener/ServerReadMetadataRepository.java
Outdated
Show resolved
Hide resolved
...s/venice-server/src/main/java/com/linkedin/venice/listener/ServerReadMetadataRepository.java
Outdated
Show resolved
Hide resolved
xunyin8
reviewed
Dec 10, 2024
.../src/main/resources/avro/StorePropertiesResponseRecord/v1/StorePropertiesResponseRecord.avsc
Show resolved
Hide resolved
xunyin8
reviewed
Dec 10, 2024
internal/venice-common/src/main/java/com/linkedin/venice/meta/ReadOnlyStore.java
Outdated
Show resolved
Hide resolved
Update fork
Update fork
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[server] Add request based store properties endpoint to server
Add endpoint to server to allow DVC to retrieve store metadata, bypassing the store based metadata retrieval. This change will not impact any behavior of the DVC during deployment. It will only add the option for the DVC to use the metadata via the endpoint. A future PR will make changes to the DVC to utilize this endpoint.
Endpoint Details
Method: GET
Path:
/store_properties/{store_name}Example Response
{ "storeMetaValue" : { "timestamp" : 1734462120342, "storeProperties" : { "name" : "venice-store_12d358cea7fe2_d3dd310e", "owner" : "store-owner_12d358cea8c94_2ee9007c", "createdTime" : 1734462116477, "currentVersion" : 1, "partitionCount" : 0, "lowWatermark" : 0, "enableWrites" : true, "enableReads" : true, "storageQuotaInByte" : 21474836480, "persistenceType" : 2, "routingStrategy" : 0, "readStrategy" : 0, "offlinePushStrategy" : 0, "largestUsedVersionNumber" : 1, "readQuotaInCU" : 1800, "hybridConfig" : null, "views" : { }, "accessControlled" : true, "compressionStrategy" : 0, "clientDecompressionEnabled" : true, "chunkingEnabled" : false, "rmdChunkingEnabled" : false, "batchGetLimit" : -1, "numVersionsToPreserve" : 0, "incrementalPushEnabled" : false, "separateRealTimeTopicEnabled" : false, "migrating" : false, "writeComputationEnabled" : false, "readComputationEnabled" : true, "bootstrapToOnlineTimeoutInHours" : 24, "leaderFollowerModelEnabled" : false, "nativeReplicationEnabled" : false, "replicationMetadataVersionID" : 0, "pushStreamSourceAddress" : "", "backupStrategy" : 1, "schemaAutoRegisteFromPushJobEnabled" : false, "latestSuperSetValueSchemaId" : -1, "hybridStoreDiskQuotaEnabled" : false, "storeMetadataSystemStoreEnabled" : false, "etlConfig" : { "etledUserProxyAccount" : "", "regularVersionETLEnabled" : false, "futureVersionETLEnabled" : false }, "partitionerConfig" : { "partitionerClass" : "com.linkedin.venice.partitioner.DefaultVenicePartitioner", "partitionerParams" : { }, "amplificationFactor" : 1 }, "incrementalPushPolicy" : 0, "latestVersionPromoteToCurrentTimestamp" : 1734462118195, "backupVersionRetentionMs" : -1, "replicationFactor" : 2, "migrationDuplicateStore" : false, "nativeReplicationSourceFabric" : "", "daVinciPushStatusStoreEnabled" : false, "storeMetaSystemStoreEnabled" : true, "activeActiveReplicationEnabled" : false, "applyTargetVersionFilterForIncPush" : false, "minCompactionLagSeconds" : -1, "maxCompactionLagSeconds" : -1, "maxRecordSizeBytes" : -1, "maxNearlineRecordSizeBytes" : -1, "unusedSchemaDeletionEnabled" : false, "versions" : [ { "storeName" : "venice-store_12d358cea7fe2_d3dd310e", "number" : 1, "createdTime" : 1734462116527, "status" : 3, "pushJobId" : "guid_id_40ea0577-5b8c-409f-96db-7955ad18d22b", "compressionStrategy" : 0, "leaderFollowerModelEnabled" : true, "nativeReplicationEnabled" : false, "pushStreamSourceAddress" : "", "bufferReplayEnabledForHybrid" : false, "chunkingEnabled" : false, "rmdChunkingEnabled" : false, "pushType" : 0, "partitionCount" : 3, "partitionerConfig" : { "partitionerClass" : "com.linkedin.venice.partitioner.DefaultVenicePartitioner", "partitionerParams" : { }, "amplificationFactor" : 1 }, "incrementalPushPolicy" : 0, "replicationFactor" : 2, "nativeReplicationSourceFabric" : "", "incrementalPushEnabled" : false, "separateRealTimeTopicEnabled" : false, "blobTransferEnabled" : false, "useVersionLevelIncrementalPushEnabled" : true, "hybridConfig" : null, "useVersionLevelHybridConfig" : true, "activeActiveReplicationEnabled" : false, "timestampMetadataVersionId" : 1, "dataRecoveryConfig" : null, "deferVersionSwap" : false, "views" : { }, "repushSourceVersion" : -1, "targetSwapRegion" : "", "targetSwapRegionWaitTime" : 60, "isDaVinciHeartBeatReported" : false } ], "systemStores" : { "venice_system_store_meta_store" : { "largestUsedVersionNumber" : 1, "currentVersion" : 1, "latestVersionPromoteToCurrentTimestamp" : 1734462120154, "versions" : [ { "storeName" : "venice_system_store_meta_store_venice-store_12d358cea7fe2_d3dd310e", "number" : 1, "createdTime" : 1734462118361, "status" : 3, "pushJobId" : "test_bootstrap_meta_system_store", "compressionStrategy" : 0, "leaderFollowerModelEnabled" : true, "nativeReplicationEnabled" : false, "pushStreamSourceAddress" : "", "bufferReplayEnabledForHybrid" : false, "chunkingEnabled" : false, "rmdChunkingEnabled" : false, "pushType" : 0, "partitionCount" : 1, "partitionerConfig" : { "partitionerClass" : "com.linkedin.venice.partitioner.DefaultVenicePartitioner", "partitionerParams" : { }, "amplificationFactor" : 1 }, "incrementalPushPolicy" : 0, "replicationFactor" : 2, "nativeReplicationSourceFabric" : "", "incrementalPushEnabled" : false, "separateRealTimeTopicEnabled" : false, "blobTransferEnabled" : false, "useVersionLevelIncrementalPushEnabled" : true, "hybridConfig" : { "rewindTimeInSeconds" : 86400, "offsetLagThresholdToGoOnline" : 1, "producerTimestampLagThresholdToGoOnlineInSeconds" : -1, "dataReplicationPolicy" : 0, "bufferReplayPolicy" : 0, "realTimeTopicName" : "" }, "useVersionLevelHybridConfig" : true, "activeActiveReplicationEnabled" : false, "timestampMetadataVersionId" : 1, "dataRecoveryConfig" : null, "deferVersionSwap" : false, "views" : { }, "repushSourceVersion" : -1, "targetSwapRegion" : "", "targetSwapRegionWaitTime" : 60, "isDaVinciHeartBeatReported" : false } ] } }, "storageNodeReadQuotaEnabled" : true, "blobTransferEnabled" : false, "nearlineProducerCompressionEnabled" : true, "nearlineProducerCountPerWriter" : 1, "targetSwapRegion" : "", "targetSwapRegionWaitTime" : 60, "isDaVinciHeartBeatReported" : false }, "storeKeySchemas" : { "keySchemaMap" : { "1" : "\"string\"" } }, "storeValueSchemas" : { "valueSchemaMap" : { "1" : "{\"type\":\"record\",\"name\":\"TestValueSchema\",\"namespace\":\"com.linkedin.venice.fastclient.schema\",\"fields\":[{\"name\":\"int_field\",\"type\":\"int\"}]}" } }, "storeValueSchema" : null, "storeReplicaStatuses" : null, "storeValueSchemaIdsWrittenPerStoreVersion" : [ -1 ], "storeClusterConfig" : null }, "helixGroupInfo" : { "https://localhost:56592" : 0, "https://localhost:56614" : 0 }, "routingInfo" : { "0" : [ "https://localhost:56592", "https://localhost:56614" ], "1" : [ "https://localhost:56592", "https://localhost:56614" ], "2" : [ "https://localhost:56592", "https://localhost:56614" ] } }How was this PR tested?
Unit and Integration test included in PR.
Does this PR introduce any user-facing changes?