-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DVC] Add RequestBasedMetaRepository to enable metadata retrieval directly from server #1467
Open
pthirun
wants to merge
4
commits into
linkedin:main
Choose a base branch
from
pthirun:feature/dvc-request-based-metadata-01-22-2025
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,186
−245
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
151 changes: 151 additions & 0 deletions
151
...inci-client/src/main/java/com/linkedin/davinci/repository/RequestBasedMetaRepository.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| package com.linkedin.davinci.repository; | ||
|
|
||
| import com.linkedin.venice.client.store.ClientConfig; | ||
| import com.linkedin.venice.client.store.D2ServiceDiscovery; | ||
| import com.linkedin.venice.client.store.transport.D2TransportClient; | ||
| import com.linkedin.venice.client.store.transport.TransportClientResponse; | ||
| import com.linkedin.venice.meta.QueryAction; | ||
| import com.linkedin.venice.meta.Store; | ||
| import com.linkedin.venice.meta.StoreConfig; | ||
| import com.linkedin.venice.meta.ZKStore; | ||
| import com.linkedin.venice.metadata.response.StorePropertiesResponseRecord; | ||
| import com.linkedin.venice.schema.SchemaData; | ||
| import com.linkedin.venice.schema.SchemaEntry; | ||
| import com.linkedin.venice.serializer.FastSerializerDeserializerFactory; | ||
| import com.linkedin.venice.serializer.RecordDeserializer; | ||
| import com.linkedin.venice.systemstore.schemas.StoreClusterConfig; | ||
| import com.linkedin.venice.systemstore.schemas.StoreProperties; | ||
| import com.linkedin.venice.utils.VeniceProperties; | ||
| import com.linkedin.venice.utils.concurrent.VeniceConcurrentHashMap; | ||
| import java.util.Map; | ||
| import org.apache.avro.Schema; | ||
|
|
||
|
|
||
| public class RequestBasedMetaRepository extends NativeMetadataRepository { | ||
|
|
||
| // cluster -> client | ||
| private final Map<String, D2TransportClient> d2TransportClientMap = new VeniceConcurrentHashMap<>(); | ||
|
|
||
| // storeName -> T | ||
| protected Map<String, SchemaData> storeSchemaMap = new VeniceConcurrentHashMap<>(); | ||
|
|
||
| private final D2TransportClient d2DiscoveryTransportClient; | ||
| private D2ServiceDiscovery d2ServiceDiscovery; | ||
|
|
||
| public RequestBasedMetaRepository(ClientConfig clientConfig, VeniceProperties backendConfig) { | ||
| super(clientConfig, backendConfig); | ||
| this.d2ServiceDiscovery = new D2ServiceDiscovery(); | ||
| this.d2DiscoveryTransportClient = | ||
| new D2TransportClient(clientConfig.getD2ServiceName(), clientConfig.getD2Client()); | ||
| } | ||
|
|
||
| @Override | ||
| public void clear() { | ||
| super.clear(); | ||
|
|
||
| // Clear cache | ||
| d2TransportClientMap.clear(); | ||
| storeSchemaMap.clear(); | ||
| } | ||
|
|
||
| @Override | ||
| protected StoreConfig fetchStoreConfigFromRemote(String storeName) { | ||
| // Create StoreConfig from D2 | ||
| D2TransportClient d2TransportClient = getD2TransportClient(storeName); | ||
|
|
||
| StoreClusterConfig storeClusterConfig = new StoreClusterConfig(); | ||
| storeClusterConfig.setStoreName(storeName); | ||
| storeClusterConfig.setCluster(d2TransportClient.getServiceName()); | ||
|
|
||
| return new StoreConfig(storeClusterConfig); | ||
| } | ||
|
|
||
| @Override | ||
| protected Store fetchStoreFromRemote(String storeName, String clusterName) { | ||
| // Fetch store, bypass cache | ||
| StorePropertiesResponseRecord record = fetchAndCacheStorePropertiesResponseRecord(storeName); | ||
| StoreProperties storeProperties = record.storeMetaValue.storeProperties; | ||
| return new ZKStore(storeProperties); | ||
| } | ||
|
|
||
| @Override | ||
| protected SchemaData getSchemaData(String storeName) { | ||
| if (!storeSchemaMap.containsKey(storeName)) { | ||
| // Cache miss | ||
| fetchAndCacheStorePropertiesResponseRecord(storeName); | ||
| } | ||
| return storeSchemaMap.get(storeName); | ||
| } | ||
|
|
||
| protected StorePropertiesResponseRecord fetchAndCacheStorePropertiesResponseRecord(String storeName) { | ||
|
|
||
| // Request | ||
| int maxValueSchemaId = getMaxValueSchemaId(storeName); | ||
| D2TransportClient d2TransportClient = getD2TransportClient(storeName); | ||
| String requestBasedStorePropertiesURL = QueryAction.STORE_PROPERTIES.toString().toLowerCase() + "/" + storeName; | ||
| if (maxValueSchemaId > SchemaData.UNKNOWN_SCHEMA_ID) { | ||
| requestBasedStorePropertiesURL += "/" + maxValueSchemaId; | ||
| } | ||
|
|
||
| TransportClientResponse response; | ||
| try { | ||
| response = d2TransportClient.get(requestBasedStorePropertiesURL).get(); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException( | ||
| "Encountered exception while trying to send store properties request to " + requestBasedStorePropertiesURL | ||
| + ": " + e); | ||
| } | ||
|
|
||
| // Deserialize | ||
| Schema writerSchema = StorePropertiesResponseRecord.SCHEMA$; | ||
| RecordDeserializer<StorePropertiesResponseRecord> recordDeserializer = FastSerializerDeserializerFactory | ||
| .getFastAvroSpecificDeserializer(writerSchema, StorePropertiesResponseRecord.class); | ||
| StorePropertiesResponseRecord record = recordDeserializer.deserialize(response.getBody()); | ||
|
|
||
| // Cache | ||
| cacheStoreSchema(storeName, record); | ||
|
|
||
| return record; | ||
| } | ||
|
|
||
| D2TransportClient getD2TransportClient(String storeName) { | ||
| synchronized (this) { | ||
| // Get cluster for store | ||
| String serverD2ServiceName = | ||
| d2ServiceDiscovery.find(d2DiscoveryTransportClient, storeName, true).getServerD2Service(); | ||
| if (d2TransportClientMap.containsKey(serverD2ServiceName)) { | ||
| return d2TransportClientMap.get(serverD2ServiceName); | ||
| } | ||
| D2TransportClient d2TransportClient = new D2TransportClient(serverD2ServiceName, clientConfig.getD2Client()); | ||
| d2TransportClientMap.put(serverD2ServiceName, d2TransportClient); | ||
| return d2TransportClient; | ||
| } | ||
| } | ||
|
|
||
| protected int getMaxValueSchemaId(String storeName) { | ||
| if (!schemaMap.containsKey(storeName)) { | ||
| return SchemaData.UNKNOWN_SCHEMA_ID; | ||
| } | ||
| return schemaMap.get(storeName).getMaxValueSchemaId(); | ||
| } | ||
|
|
||
| protected void cacheStoreSchema(String storeName, StorePropertiesResponseRecord record) { | ||
| if (!storeSchemaMap.containsKey(storeName)) { | ||
| // New store | ||
| Map.Entry<CharSequence, CharSequence> keySchemaEntry = | ||
| record.getStoreMetaValue().getStoreKeySchemas().getKeySchemaMap().entrySet().iterator().next(); | ||
| SchemaData schemaData = new SchemaData( | ||
| storeName, | ||
| new SchemaEntry(Integer.parseInt(keySchemaEntry.getKey().toString()), keySchemaEntry.getValue().toString())); | ||
| storeSchemaMap.put(storeName, schemaData); | ||
| } | ||
| // Store Value Schemas | ||
| for (Map.Entry<CharSequence, CharSequence> entry: record.getStoreMetaValue() | ||
| .getStoreValueSchemas() | ||
| .getValueSchemaMap() | ||
| .entrySet()) { | ||
| storeSchemaMap.get(storeName) | ||
| .addValueSchema(new SchemaEntry(Integer.parseInt(entry.getKey().toString()), entry.getValue().toString())); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the
finalhere so we may initialize this map in unit test mocking.