-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[router][common] Multiple fixes in Opentelemetry #1483
Conversation
… default 2. Change venice.response.status_code_category to hold success/fail instead of healthy/unhealthy/tardy/throttled/bad_request 3. Change the existing tehuti metrics key_num and bad_request_key_num to record metrics(1) for single gets as well to keep things uniform 4. Introduce otel metric incoming_key_count that will measure the data similar to key_num and bad_request_key_num at request handling path 5. change otel metic call_key_count to key_count which will now measures key counts on the response handling side with success/fail details as well as response codes
...-common/src/main/java/com/linkedin/venice/stats/dimensions/VeniceResponseStatusCategory.java
Show resolved
Hide resolved
services/venice-router/src/main/java/com/linkedin/venice/router/api/VenicePathParser.java
Outdated
Show resolved
Hide resolved
...ces/venice-router/src/test/java/com/linkedin/venice/router/stats/RouterMetricEntityTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes overall look good, I'm giving a provisional ship it pending some of the things I've asked. I think overall I have some latent concern about the enum tweak and the potential new overhead for single key lookup, but aside from that I don't have any major objections. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ZacAttack for the review. Replied to your comments.
...-common/src/main/java/com/linkedin/venice/stats/dimensions/VeniceResponseStatusCategory.java
Show resolved
Hide resolved
...ces/venice-router/src/test/java/com/linkedin/venice/router/stats/RouterMetricEntityTest.java
Outdated
Show resolved
Hide resolved
services/venice-router/src/main/java/com/linkedin/venice/router/api/VenicePathParser.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and it makes sense to me!
Thanks @ZacAttack and @lluwm for the review |
Summary
otel.venice.metrics.export.interval.in.seconds
for OpenTelemetry (OTel) metrics export, with a default value of60
seconds which is the same without this config right now.MetricEntityState
to maintain a 1:1 relationship between OTel instruments and Tehuti sensors, rather than a 1:n relationship, to eliminate unnecessary lookups during the hot path.total
store in the router. The aggregation will be done on the receiving side. This will be helpful during creation of pre-aggregates in the metrics processing systems by not having to dostoreName != total
.venice.response.status_code_category
to usesuccess/fail
instead ofhealthy/unhealthy/tardy/throttled/bad_request
to keep it standard.Tardy/throttled/bad_request
can be inferred from the response status.request
as it was not covering all the incoming cases either and this was making things more confusing.call_key_count
tokey_count
and converted it into a histogram. This metric will now measure key counts on the response handling side, including success/fail details and response codes, similar tocall_time
, and will provide a distribution for key counts.How was this PR tested?
GH CI and below log via integration tests shows all the new changes
Does this PR introduce any user-facing changes?
otel.venice.metrics.export.interval.in.seconds
config with a default value of60
seconds.venice.response.status_code_category
dimension will emit valuessuccess/fail