Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protocol] Add StoreMetaValue schema v28 to introduce largestUsedRTVersionNumber for RT version tracking #1520

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

arjun4084346
Copy link
Contributor

@arjun4084346 arjun4084346 commented Feb 11, 2025

Adding a field largestUsedRTVersionNumber in StoreMetaValue schema

When we delete and recreate a store, we do not want to use the same old real time topic name, because that might not have been fully cleaned up. We want to use a new name, and in order to do so we need to know the previous name that was ever used. This config will keep the largestUsedRTVersionNumber that was ever used and help in creating a new name whenever needed.

schema difference -

abora-mn3:StoreMetaValue abora$ diff v27/StoreMetaValue.avsc v28/StoreMetaValue.avsc 
34a35
>             {"name": "largestUsedRTVersionNumber", "type": "int", "default": 0, "doc": "The largest version number for the real time topic ever used before for this store."},
266a268
>                     {"name": "largestUsedRTVersionNumber", "type": "int", "default": 0},

Resolves #XXX

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@arjun4084346 arjun4084346 reopened this Feb 11, 2025
@arjun4084346 arjun4084346 force-pushed the rtversionschema branch 2 times, most recently from 470a2ec to dec6448 Compare February 11, 2025 22:39
build.gradle Outdated Show resolved Hide resolved
@arjun4084346 arjun4084346 changed the title [compat] add a field largestUsedRTVersionNumber in store config [protocol] add a field largestUsedRTVersionNumber in store config Feb 11, 2025
@sushantmane
Copy link
Collaborator

sushantmane commented Feb 11, 2025

Can you improve the commit message? Specifically, include the name of the new schema file being added and its version to make it easier to reference in release notes and quickly understand the changes. Also, use the protocol tag instead of compact, as the new schema is not yet in use.

For example:
[protocol] Add StoreMetaValue schema v28 to introduce maxUsedRTVersionNumber for RT version tracking

@arjun4084346 arjun4084346 changed the title [protocol] add a field largestUsedRTVersionNumber in store config [protocol] Add StoreMetaValue schema v28 to introduce largestUsedRTVersionNumber for RT version tracking Feb 11, 2025
Copy link
Collaborator

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When doing Squash and merge, please don't forget to cleanup the commit message and format it so that there are less than 100 chars per line. Thanks.

@arjun4084346 arjun4084346 enabled auto-merge (squash) February 12, 2025 00:17
@arjun4084346 arjun4084346 merged commit aa7dd9a into linkedin:main Feb 12, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants