[router][server] ACL optimization #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
High-level idea: 1. For a keep-alive connection, the client cert will never change, so for the same store, it is useless to validate each request on the same connection. 2. In Server, there is an Acl Handler called `ServerAclHandler`, which is used to validate whether the connection is from Venice Router or not via static ACL. For each connection, Server will buffer the ACL check result in this attribute key: `SERVER_ACL_APPROVED_ATTRIBUTE_KEY`. And the ACL check result won't change during the lifetime of the Server instance. 3. In both Router and Server, there is a store-level ACL check, which can change during the lifetime of the Router/Server (ACL added/removed). The caching idea is a little different from linkedin#2, and it will maintain a cache map in the original connection, and for all the requests coming from this particular connection, it will check the acl check cache map first, and it will follow the previous result if the cache entry is not expired. If there is no such entry or the cache entry is expired, it will resort to the underlying access control to update the cache map. In theory, the acl check against the access controller will be minimized a lot. New config: acl.in.memory.cache.ttl.ms: 60000 (by default)
FelixGV
reviewed
Feb 11, 2025
...nal/venice-common/src/main/java/com/linkedin/venice/acl/handler/AbstractStoreAclHandler.java
Outdated
Show resolved
Hide resolved
...nal/venice-common/src/main/java/com/linkedin/venice/acl/handler/AbstractStoreAclHandler.java
Outdated
Show resolved
Hide resolved
...nal/venice-common/src/main/java/com/linkedin/venice/acl/handler/AbstractStoreAclHandler.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High-level idea:
ServerAclHandler, which is used to validate whether the connection is from Venice Router or not via static ACL. For each connection, Server will buffer the ACL check result in this attribute key:SERVER_ACL_APPROVED_ATTRIBUTE_KEY. And the ACL check result won't change during the lifetime of the Server instance.New config:
acl.in.memory.cache.ttl.ms: -1 (by default)
If the ttl config value is <= 0, the store-level acl caching will be disabled.
How was this PR tested?
CI
Does this PR introduce any user-facing changes?