-
Notifications
You must be signed in to change notification settings - Fork 114
[doc] Migrate Venice docs from Jekyll to MkDocs Material and improve documentation #2361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ZacAttack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hasn't seemed to have moved much, so I'm willing it take the initiative and ship. As a I recall most of this was copied from the the original.
|
Last time we discussed about this, the content was mostly copied over. However, I made some more changes. Ex: added missing documentation for thin, fast, and CDC clients. The CDC one is mostly imported from a document I wrote internally. |
mynameborat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for improving these. I looked at the documentation changes in your github hosted site.
Should we do any work to deploy these once merged? Or will it automatically update the website with the changes?
|
@mynameborat Thanks for taking a look. I've updated the GitHub actions in this PR to automatically deploy the site on every commit merged to main. |
Problem Statement
Solution
Migrating to MkDocs Material addresses 1-3.
4: Moved some pages around to better locations so it's less confusing for first-time users.
5: Updated outdated documentation such as "AA is still under development."
6. Added documentation for Thin, Fast, and CDC clients.
7. Improved documentation for Stream Processor and Da Vinci Client and added code examples.
8: Added Markdown prettier that automatically wraps lines that exceed 120 characters during pre-commit.
New docs can be viewed here.
JavaDocs still work too.
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized,RWLock) are used where needed.ConcurrentHashMap,CopyOnWriteArrayList).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?
Links for pages are changed.