[Controller] Add gRPC support for getFutureVersion API #2427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pthirun
force-pushed
the
controller-grpc-migration-get-future-version
branch
from
eb22c62 to
5240ed1
Compare
- Add GetFutureVersionGrpcRequest/Response proto messages - Add getFutureVersion RPC to VeniceControllerGrpcService - Add getFutureVersion handler method in VeniceControllerRequestHandler - Update VeniceControllerGrpcServiceImpl to implement the RPC - Update StoresRoutes.getFutureVersion to use the handler - Add VeniceNoStoreException handling in ControllerGrpcServerUtils - Add comprehensive unit tests Co-Authored-By: Claude Opus 4.5 <[email protected]>
pthirun
force-pushed
the
controller-grpc-migration-get-future-version
branch
from
5240ed1 to
69ccd4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getFutureVersionendpointVeniceControllerRequestHandler.getFutureVersion()VeniceNoStoreExceptionin gRPC error handlingChanges
GetFutureVersionGrpcRequestandGetFutureVersionGrpcResponseproto messagesgetFutureVersionRPC toVeniceControllerGrpcServicegetFutureVersionhandler method inVeniceControllerRequestHandlerVeniceControllerGrpcServiceImplto implement the RPCStoresRoutes.getFutureVersionto use the handlerVeniceNoStoreExceptionhandling inControllerGrpcServerUtilsto return NOT_FOUND statusTest plan
VeniceControllerRequestHandlerTest.testGetFutureVersion*VeniceControllerGrpcServiceImplTest.testGetFutureVersionStoresRoutesTest.testGetFutureVersion*VALIDATION_OVERRIDE
🤖 Generated with Claude Code