[common][compat] Add previousCurrentVersion field to track version swap history #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap history When a version is promoted to current via setCurrentVersion(), the new current version's previousCurrentVersion field is automatically set to the old current version number. This allows tracking which version was serving before a version swap occurred. Key changes: - Added previousCurrentVersion field to Version and Store interfaces - Implemented auto-set logic in ZKStore.setCurrentVersion() - setCurrentVersionWithoutCheck() does NOT trigger auto-set (for deserialization) - Default value is -1 (Store.NON_EXISTING_VERSION) - Bumped StoreMetaValue schema from v39 to v40 - Set blobDbEnabled to default value in VeniceParentHelixAdmin to fix NPE Co-Authored-By: Claude Opus 4.5 <[email protected]>
…es and fix blobDbEnabled serialization - Bump AdminOperation protocol from v94 to v95 - Add PREVIOUS_CURRENT_VERSION constant to ControllerApiConstants - Add getter/setter for previousCurrentVersion in UpdateStoreQueryParams - Wire previousCurrentVersion from parent controller through admin message to child controller - Apply previousCurrentVersion in VeniceHelixAdmin.updateStore() - Fix blobDbEnabled null serialization errors by setting default value "NOT_SPECIFIED" in: - cloneStoreProperties() for store-level serialization - convertVersion() for version-level serialization Co-Authored-By: Claude Opus 4.5 <[email protected]>
Tests that create UpdateStore admin messages directly must set blobDbEnabled = "NOT_SPECIFIED" to avoid NullPointerException when serializing with AdminOperation schema v95 which added this field as a required non-nullable string. Affected tests: - AdminConsumptionTaskTest.testSetStore - AdminOperationSerializerTest.testAdminOperationSerializer - AdminOperationSerializerTest.testValidateAdminOperation - SemanticDetectorTest.testTraverse - SemanticDetectorTest.testDefaultFieldValue - AdminConsumptionTaskIntegrationTest.getStoreUpdateMessage - AdminConsumptionWithProtocolRollbackIntegrationTest.getStoreUpdateMessage - TestMultiDataCenterAdminOperations.getStoreUpdateMessage Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Need to track which version was current before a version swap occurred for debugging and deferred version swap functionality.
Solution
previousCurrentVersionfield to Version and Store interfaces to track which version was current before a version swapsetCurrentVersion()is called, the NEW current version'spreviousCurrentVersionis automatically set to the old current version numbersetCurrentVersionWithoutCheck()does NOT trigger auto-set (used for deserialization)Store.NON_EXISTING_VERSION)blobDbEnabledto default value in VeniceParentHelixAdminCode changes
Concurrency-Specific Checks
How was this PR tested?
New unit tests added.
New integration tests added.
Modified or extended existing tests.
Verified backward compatibility (if applicable).
Unit tests added in
ReadOnlyStoreTest.javafor auto-set behaviorIntegration test extended in
TestDeferredVersionSwapWithSequentialRollout.javato verifypreviousCurrentVersionafter version swapDoes this PR introduce any user-facing or breaking changes?