[controller] Disallow store migration actions on child controllers #2459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add isParent() guards to migrateStore, completeMigration, abortMigration, and autoMigrateStore route handlers in StoresRoutes so that migration requests sent directly to child controllers are rejected with BAD_REQUEST. Internal admin message consumption (via AdminExecutionTask) is unaffected since it does not go through these HTTP routes. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Currently, users can send migration requests to child controllers by mistake which causes the store and its metadata in a weird state resulting in unusable state.
Code changes
Add isParent() guards to migrateStore, completeMigration, abortMigration, and autoMigrateStore route handlers in StoresRoutes so that migration requests sent directly to child controllers are rejected with BAD_REQUEST. Internal admin message consumption (via AdminExecutionTask) is unaffected since it does not go through these HTTP routes.
How was this PR tested?
Does this PR introduce any user-facing or breaking changes?