[server] Update CV state cleanup to run at the instance level rather than per partition. #2474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
When a Venice server node undergoes a disk swap and stop/restarts ungracefully, stale Helix Customized View states remain in ZooKeeper, causing routers to incorrectly treat the host as ready to serve traffic before it's actually prepared.
Timeline:
Root Cause:
The existing resetAllInstanceCVStates() implementation relies on disk-based partition discovery. getStoreAndUserPartitionsMapping() calls engine.getPersistedPartitionIds(), which only returns partitions currently on disk. When disk state is empty or inconsistent, this returns an empty map, causing CV cleanup to be silently skipped.
Solution
Replace the disk-based partition discovery approach with Helix's bulk delete API (deleteAllResourcesCustomizedStates()), which directly queries ZooKeeper for all resources with CV states, regardless of local disk state.
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized,RWLock) are used where needed.ConcurrentHashMap,CopyOnWriteArrayList).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?