[vpj] Fixing a bug with chunked messages in Repush #2480
Merged
+96
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Spark KIF repush fails for stores with chunking enabled due to two bugs:
validateDataFrame()rejects all fields starting with _, but chunked KIF DataFrames contain Venice internal columns(__schema_id__, __offset__, __message_type__, __chunked_key_suffix__, __replication_metadata_version_id__)that are required for chunk assembly. These columns are consumed byapplyChunkAssembly()and dropped later inrunComputeJob(), but validation runs before they are dropped.NotSerializableExceptionin Spark lambdas: The lambdas in applyChunkAssembly() and applyTTLFilter() reference the instance field accumulatorsForDataWriterJob directly, which capturesDataWriterSparkJob. SinceDataWriterSparkJobdoesn't implement Serializable, Spark fails when serializing the task to send to executors.Solution
validateDataFrame(), whenisSourceKafkais true, the five known Venice internal column names are added to an allowlist and exempted from the underscore check. For regular VPJ unknownunderscore columns are still rejected.
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized,RWLock) are used where needed.ConcurrentHashMap,CopyOnWriteArrayList).How was this PR tested?
The PR was tested against a test instance in airflow rdev http://rdev-aks-wus3-14.privatelink.westus3.azmk8s.io:42229/dags/vpj-spark-repush-test_faro__voldemort-build-and-push/grid?dag_run_id=manual__2026-02-12T18%3A23%3A00.588766%2B00%3A00&task_id=spark_repush_job&tab=logs
Does this PR introduce any user-facing or breaking changes?