chore(deps): add prost and tonic dependabot groups
#455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit adds two groups to the dependabot configuration. this will mean that dependabot updates (a) `tonic` and `tonic-build,` and (b) `prost` and `prost-types`, in lockstep. Signed-off-by: katelyn martin <[email protected]>
This was referenced Mar 26, 2025
sfleen
approved these changes
Mar 26, 2025
olix0r
reviewed
Mar 27, 2025
Comment on lines
+7
to
+13
| groups: | ||
| prost: | ||
| patterns: | ||
| - "prost*" | ||
| tonic: | ||
| patterns: | ||
| - "tonic*" |
There was a problem hiding this comment.
Don't these dependencies have to be updated together?
There was a problem hiding this comment.
good question. i noticed these are not maintained as part of the same organization (see repository url's below), and we don't update these together in the proxy at the moment.
i think you're right though. prost generates code based on the tonic interfaces, so.. we should probably do the same thing as the control plane.
There was a problem hiding this comment.
linkerd/linkerd2-proxy#3821 consolidates these groups together. i can do the same here, i'll mark this as a draft in the meantime.
cratelyn
added a commit
to linkerd/linkerd2-proxy
that referenced
this pull request
Mar 27, 2025
* https://github.com/linkerd/linkerd2/blob/main/.github/dependabot.yml#L81-L86 * #3809 * linkerd/linkerd2-proxy-api#455 (comment) tonic and prost are interconnected. we should bump them in lockstep. Signed-off-by: katelyn martin <[email protected]>
olix0r
pushed a commit
to linkerd/linkerd2-proxy
that referenced
this pull request
Mar 31, 2025
* https://github.com/linkerd/linkerd2/blob/main/.github/dependabot.yml#L81-L86 * #3809 * linkerd/linkerd2-proxy-api#455 (comment) tonic and prost are interconnected. we should bump them in lockstep. Signed-off-by: katelyn martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit adds two groups to the dependabot configuration.
this will mean that dependabot updates (a)
tonicandtonic-build,and (b)prostandprost-types, in lockstep.