refactor(app/outbound): decompose grpc and http labeling #4252
+166
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
this commit introduces `apply()` methods to `HttpRsp` and `GrpcRsp`. this allows us to collect both the response status and response error when a body encounters an error whilst polling. Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
cratelyn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nb: this branch is based upon #4250 and #4251.
this branch re-frames the outbound proxy's stream labeling facilities in terms of the constituent status and error labeling facilities introduced to the
linkerd-http-promlibrary in #4251.feat(app/outbound): convenience constructors for
HttpRsp,GrpcRspSigned-off-by: katelyn martin [email protected]
feat(app/outbound):
GrpcRsp,HttpRspareFrom<&Error>Signed-off-by: katelyn martin [email protected]
feat(app/outbound):
GrpcRspandHttpRspcan be mergedthis commit introduces
apply()methods toHttpRspandGrpcRsp.this allows us to collect both the response status and response error
when a body encounters an error whilst polling.
Signed-off-by: katelyn martin [email protected]
refactor(app/outbound):
LabelHttpRspusesLabelHttpStatusSigned-off-by: katelyn martin [email protected]
refactor(app/outbound):
LabelGrpcRspusesLabelGrpcStatusSigned-off-by: katelyn martin [email protected]