Add data mapping to Makefile #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twhetzel
reviewed
Nov 13, 2025
Collaborator
Author
ptgolden
requested changes
Nov 18, 2025
Collaborator
ptgolden
left a comment
ptgolden
left a comment
There was a problem hiding this comment.
This is great, Corey! There's just a few things that need clearing up-- see my inline comments.
I'd also like to chat more generally about the proliferation of configurable options. This is totally fine-- and inevitable!-- but we might want to talk about how we organize & document them.
Collaborator
|
Should the prefix and postfix have default values? Is it okay if they're blank? |
ptgolden
approved these changes
Dec 19, 2025
Collaborator
ptgolden
left a comment
ptgolden
left a comment
There was a problem hiding this comment.
Great! If there's anything else we find, we can address them in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the data mapping script to the pipeline.Makefile. I'll want to test this before we finalize but I think it's just about ready.