Refactor map_data script #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds type annotations throughout. There is one place where I have a `type: ignore` comment. It's because of an incomplete type annotation in the flatten_dict library * With the type annotations in place, moved the CLI interface from argparse to typer. * Adds discrete `Stream` classes (e.g. TSVStream, JSONStream, etc.) rather than having stream functions that all must take every single kwarg required for any stream. This makes things a little clearer: for example, a "JSONLStream" doesn't require a `key_name` parameter. It also allows tracking state on a stream object-- before, the operation of the TSV stream relied on tracking some global state attached to the function. NOTE: I have not run these changes against the tests yet. There's probably some more work to do there.
Collaborator
Author
|
Other small things I forgot to mention:
|
amc-corey-cox
approved these changes
Dec 19, 2025
Collaborator
amc-corey-cox
left a comment
amc-corey-cox
left a comment
There was a problem hiding this comment.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds type annotations throughout. There is one place where I have a
type: ignorecomment. It's because of an incomplete type annotation in the flatten_dict libraryWith the type annotations in place, moved the CLI interface from argparse to typer.
Adds discrete
Streamclasses (e.g. TSVStream, JSONStream, etc.) rather than having stream functions that all must take every single kwarg required for any stream. This makes things a little clearer: for example, a "JSONLStream" doesn't require akey_nameparameter. It also allows tracking state on a stream object-- before, the operation of the TSV stream relied on tracking some global state attached to the function.NOTE: I have not run these changes against the tests yet. There's probably some more work to do there.