Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention poetry 2.0 requirement #131

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

dalito
Copy link
Member

@dalito dalito commented Feb 4, 2025

I also added a note on the (new-to-me) option to have poetry 1.0 and 2.0 installed at the same time.

Closes #129

@dalito dalito force-pushed the issue129-document-poetry2 branch from 6401711 to e9953a3 Compare February 4, 2025 20:20
@dalito dalito force-pushed the issue129-document-poetry2 branch from e9953a3 to b4c2b76 Compare February 4, 2025 20:20
@dalito dalito requested a review from amc-corey-cox February 9, 2025 13:24
Copy link
Contributor

@amc-corey-cox amc-corey-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check what's going on with formatting in lines 10-15. Otherwise this is good to go. It's fine either way, I'd just like to understand. I'll merge when I hear back.


pipx is a tool for managing isolated Python-based applications. It is the recommended way to install Poetry and cruft. To install pipx follow the instructions here: https://pypa.github.io/pipx/installation/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did something change here or is GitHub just acting weird? Whatever it is happened a couple lines up, too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised as well. GH-diff gets puzzled on the change from two empty lines 17/18 to one 16 (or 12/13 to 12).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I suspect it was something odd like that.

@amc-corey-cox amc-corey-cox merged commit 13d8039 into linkml:main Feb 10, 2025
1 check passed
@dalito dalito deleted the issue129-document-poetry2 branch February 11, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document poetry2 requirement
2 participants