Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isodate as dependency #377

Closed
wants to merge 1 commit into from
Closed

Conversation

will-0
Copy link
Contributor

@will-0 will-0 commented Mar 24, 2025

isodate used since a1a6b48, but not added as dependency.

@will-0 will-0 marked this pull request as ready for review March 24, 2025 17:08
@dalito
Copy link
Member

dalito commented Mar 24, 2025

isodate is currently included via rdflib. rdflib specifies it currently as isodate = {version=">=0.7.2,<1.0.0", python = "<3.11"}.

In linkml-runtime we should also add it only for python <3.11.

@will-0
Copy link
Contributor Author

will-0 commented Mar 24, 2025

Makes sense. How does it work if you're using higher python versions then? My project was failing due to the missed dependency on python 3.12

@dalito
Copy link
Member

dalito commented Mar 24, 2025

Ah. The import should also depend on the Python version. I should have done that in #357 (surprising that the tests passed). Can you add the conditional import to your PR? isodate is only imported here

@dalito
Copy link
Member

dalito commented Mar 27, 2025

@will-0 - FYI: I submitted #380 to solve the issue by making the import Python version dependent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants