-
Notifications
You must be signed in to change notification settings - Fork 31
restore dataclass_extensions. See #345 #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
+ Coverage 63.76% 63.79% +0.02%
==========================================
Files 62 63 +1
Lines 8945 8951 +6
Branches 2587 2587
==========================================
+ Hits 5704 5710 +6
Misses 2634 2634
Partials 607 607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
#345 also removed the test for this code which was in the file |
This looks like it's failing some of the downstream linkml tests. I looked at the first one, which dates back to: The test is
def test_alt_description_2(input_path):
with pytest.raises(ValueError, match="description must be supplied"):
YAMLGenerator(input_path("issue_326a.yaml")).serialize(validateonly=True) This is a little rigid. An exception is still raised, but with the changes in #345, the reason/exception type/message changes (since it is now caught at Same with
def test_representation_errors(input_path):
"""Test malformed schema elements"""
fn = input_path("typeerror1.yaml")
with pytest.raises(ValueError):
SchemaLoader(fn) and
def test_not_a_valid_schema():
instance = {}
schema = {"foo": "bar"}
with pytest.raises(ValueError, match="Invalid schema"):
validate(instance, schema) These tests have been switched to use the regenerated linkml-model code but they have become too rigid in the other direction What I am surprised about is how this made it through before.. |
emit warnings for python 3.13
This seems to fail because dynamic versioning has to be installed differently with poetry 2.x After |
🍏 📗 🟢 💚 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥗
upstream_repo: linkml/linkml
upstream_branch: pr-2358
This was prematurely removed in #345. A lot of existing code depends on this
Note the changes from #345 temporarily made their way into a 1.9.0 release, but this was promptly yanked