This repository was archived by the owner on Apr 16, 2026. It is now read-only.
Repository navigation
schemaview.py: reorder relationships - #465
Merged
Merged
Conversation
…/descendants, etc)
…the _closure function to remove some redundancy
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 77.48% 77.48% -0.01%
==========================================
Files 52 52
Lines 4464 4459 -5
Branches 970 968 -2
==========================================
- Hits 3459 3455 -4
Misses 781 781
+ Partials 224 223 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ialarmedalien
commented
Oct 6, 2025
| i = todo[0] | ||
| todo = todo[1:] | ||
| while todo: | ||
| i = todo.pop() if depth_first else todo.pop(0) |
Collaborator
Author
There was a problem hiding this comment.
i = list.pop(0) pops the first entry off the list
kevinschaper
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll fix this branch up after #466 and #467 are dealt with.
Some minor edits:
Commit 1, b5733f5
class_parents,class_ancestors,class_children,class_descendants,class_roots, andclass_leavestogether, and similarly for the other entity types).Commit 2, 2989a50
**kwargsto the functions that call_closure(...)to allow the use of kwargs (surprise!)_closurefunction to simplify how it is written