Add vpcless flavor #289
Merged
Add vpcless flavor #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage 60.57% 60.57%
=======================================
Files 30 30
Lines 1750 1750
=======================================
Hits 1060 1060
Misses 644 644
Partials 46 46 ☔ View full report in Codecov by Sentry. |
4 tasks
eljohnson92
reviewed
Apr 26, 2024
eljohnson92
reviewed
Apr 26, 2024
eljohnson92
approved these changes
Apr 26, 2024
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
* add kubeadm-vpcless flavor * add VPC documentation * address review comments * fix matchexpressions for cilium addons * address review comments, fix cni install for dual-stack --------- Co-authored-by: Rahul Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it: This creates a new flavor "vpcless" to provision k8s clusters outside of VPC. This is needed for regions which don't have VPC support.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: