Skip to content

[deprecation] Deprecate stackscript #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025
Merged

Conversation

Andrews2024
Copy link
Contributor

@Andrews2024 Andrews2024 commented Apr 1, 2025

What this PR does / why we need it:
This PR keeps the CloudinitMetadataSupport field in the API for backwards compatibility but otherwise removes support for stackscript. Cloud-init is sufficiently supported so that stackscript can be removed.

TODOs:

  • squashed commits
  • includes documentation
  • updates e2e tests

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.22%. Comparing base (15be027) to head (bbf28cf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nal/controller/linodemachine_controller_helpers.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   65.38%   65.22%   -0.16%     
==========================================
  Files          70       69       -1     
  Lines        6647     6597      -50     
==========================================
- Hits         4346     4303      -43     
+ Misses       2046     2041       -5     
+ Partials      255      253       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andrews2024 Andrews2024 merged commit c68a6c3 into main Apr 1, 2025
12 of 13 checks passed
@Andrews2024 Andrews2024 deleted the deprecate-stackscript branch April 1, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants