Skip to content

Commit

Permalink
Removing bubbling via function.
Browse files Browse the repository at this point in the history
  • Loading branch information
fkurmannucsc committed Jul 2, 2024
1 parent cbd4d74 commit 0afadc0
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions static/js/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,35 +161,33 @@ function initVideo(info) {
<input type='text' name='name'
data-video-id='${info.video_id}'
onchange='editVideo(this, "name")'
onkeydown='event.stopPropagation()'
value='${info.original_name}' />
</div>
<div>
<label for='name'>Video Start Time:</label>
<input type='datetime-local' name='start_time'
data-video-id='${info.video_id}'
onchange='editVideo(this, "start_time")'
onkeydown='event.stopPropagation()'
value='${start_time_input_value}' />
</div>
<div>
<label for='latitude'>Latitude:</label>
<input type='number' name='latitude' step='0.01'
data-video-id='${info.video_id}'
onchange='editVideo(this, "latitude")'
onkeydown='event.stopPropagation()'
value='${latitude}' />
</div>
<div>
<label for='longitude'>Longitude:</label>
<input type='number' name='longitude' step='0.01'
data-video-id='${info.video_id}'
onchange='editVideo(this, "longitude")'
onkeydown='event.stopPropagation()'
value='${longitude}' />
</div>
</div>
`;

removeKeydownSideEffects();
}

function toggleSelection() {
Expand Down Expand Up @@ -238,7 +236,6 @@ function addScreenshot(screenshot) {
<label for='name'>Name:</label>
<input type='text' name='name'
onchange='editScreenshot(this, "${screenshot.id}", "name")'
onkeydown='event.stopPropagation()'
value='${screenshot.name}' />
</div>
<div>
Expand All @@ -259,6 +256,8 @@ function addScreenshot(screenshot) {
</div>
`;

removeKeydownSideEffects();

document.querySelector('.screenshot-area').insertAdjacentHTML('afterbegin', html);
}

Expand Down Expand Up @@ -469,9 +468,16 @@ function initializeHotkeys() {
});
}

function removeKeydownSideEffects() {
document.querySelectorAll('input[type="text"]').forEach((input) => {
input.setAttribute('onkeydown', 'event.stopPropagation()');
});
}

function main() {
fetchVersion();
initializeHotkeys();
removeKeydownSideEffects();
goToUploadScreen();
}

Expand Down

0 comments on commit 0afadc0

Please sign in to comment.