Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete hotkey added #14

Closed
wants to merge 2 commits into from
Closed

Delete hotkey added #14

wants to merge 2 commits into from

Conversation

fkurmannucsc
Copy link
Contributor

Added a delete hotkey to remove the uppermost item in the screenshot area.

Copy link
Member

@eriq-augustine eriq-augustine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really think this hotkey should exist.
Since we don't currently have a concept of the "selected" screenshot, I don't think we should have a universal hotkey for it.

@fkurmannucsc
Copy link
Contributor Author

I don't really think this hotkey should exist. Since we don't currently have a concept of the "selected" screenshot, I don't think we should have a universal hotkey for it.

I agree that having a notion of which screenshot is selected would make sense. Perhaps the selected screenshots should be highlighted somehow and then with the up/down arrows users can navigate which screenshot is selected. May be a larger item but I could start to implement this.

@eriq-augustine
Copy link
Member

I agree that having a notion of which screenshot is selected would make sense. Perhaps the selected screenshots should be highlighted somehow and then with the up/down arrows users can navigate which screenshot is selected. May be a larger item but I could start to implement this.

I think you may have missed my point.

This PR doesn't make sense without the selection functionality.
And I am not convinced that we need the selection functionality.
So I think this PR should be dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants