lzfse/: cleanup files #91
Conversation
Linux kernel coding styles require SPDX headers at the top of each file. Signed-off-by: Ethan Carter Edwards <[email protected]>
clang-format is used in the mainline to format files. Additionally, there are occasional #if's used to see if the windows compiler is used. Obviously, the windows compiler will not be used to compile the kernel. We can safely remove them. Signed-off-by: Ethan Carter Edwards <[email protected]>
|
I haven't reviewed this yet, but keep in mind that the kernel has its own style checker in tree, it's a script called |
|
There is an in-tree kernel configuring file for I am aware of checkpatch.pl, but |
|
Ah, I didn't know about that. Then I guess it's fine. |
|
The comment style didn't get fixed, in fact it got broken in a new way in some places. Weird, I guess clang-format doesn't cover everything. |
|
Ah. Good to know. I'll fix soon, thanks. |
|
I've been cleaning this up myself, so I think I can close this now. Thanks anyway. |
To be merged into the mainline kernel, these library files need to be cleaned up. Correcting the license headers and formatting the code with
clang-formatis a good start.Additionally, some of the C files are not used/compiled into the final module. I understand that you have probably kept them around for future implementations, however, since they are not used, should they just be removed? Especially the
lzfse_main.cfile?