Ask the user for consent before polling for updates online #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnez
force-pushed
the
update-poll-consent
branch
from
0904e85 to
d6164e6
Compare
|
Fixed the "to to" typo seen in the first screenshot. |
fiurin
reviewed
Nov 24, 2023
fiurin
reviewed
Nov 24, 2023
hnez
force-pushed
the
update-poll-consent
branch
from
d6164e6 to
b5b478e
Compare
fiurin
reviewed
Dec 5, 2023
hnez
force-pushed
the
update-poll-consent
branch
from
b5b478e to
075d7c6
Compare
jluebbe
approved these changes
Jan 11, 2024
This convenience method allows you to wait until a topic holds a specified value. Signed-off-by: Leonard Göhrs <[email protected]>
Polling for updates should only be done with user consent as it creates a connection to our server, which has privacy implications. Signed-off-by: Leonard Göhrs <[email protected]>
Signed-off-by: Leonard Göhrs <[email protected]>
No need to show a spinner if polling for updates is not enabled etc.. Signed-off-by: Leonard Göhrs <[email protected]>
Signed-off-by: Leonard Göhrs <[email protected]>
hnez
force-pushed
the
update-poll-consent
branch
from
075d7c6 to
5a3edce
Compare
This is a trick that cargo clippy has recently learned, which means we need it to make the CI pipeline succeed. Signed-off-by: Leonard Göhrs <[email protected]>
…gpio Clippy disallows #[cfg(test)] mods that are followed by other code by default[1] and usually this makes sense, because tests should be at the end of the file, but in our case the mod does not contain tests but instead imports a test-specific variant of the gpio mod. Allow that. [1]: https://rust-lang.github.io/rust-clippy/master/index.html#/items_after_test_module Signed-off-by: Leonard Göhrs <[email protected]>
|
It looks like @jluebbe this has invalidated the previous approval, could you have a second look? |
jluebbe
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phoning home for software updates without asking for any kind of consent is bad practice and (rightfully) breaks user's trust.
So we shouldn't do it.
tacd's API that is persisted to disk and configures wether there should be polling for updates.The setup wizard page:
The dashboard panel when update polling is enabled:
The dashboard panel when update polling is disabled (and its effect on the "Channel Enabled" and "Channel Polling Interval" table columns):
Related Pull Requests
This PR is based on another PR that should be merged first: