Fix cargo clippy issues #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was suggested by cargo clippy. Signed-off-by: Leonard Göhrs <[email protected]>
There is a nice symmetry with all resources being collected in UiResources. Do not break that just because this resource is not read again. Signed-off-by: Leonard Göhrs <[email protected]>
AsRef is always available, no need to import it. This was suggested by cargo clippy. Signed-off-by: Leonard Göhrs <[email protected]>
The mock trait is based on one provided by the sysfs_class crate. But we do not actually use some of the methods it has, so we can remove their implementation. This change was suggested by cargo clippy. Signed-off-by: Leonard Göhrs <[email protected]>
The mock trait is based on one provided by the sysfs_class crate. But we do not actually use some of the methods it has, so we can remove their implementation. This change was suggested by cargo clippy. Signed-off-by: Leonard Göhrs <[email protected]>
It turns out we do not actually read any inputs in our tests, so we can remove this implementation. This change was prompted by cargo clippy complaining about the u8 in LineEvent never being read. Signed-off-by: Leonard Göhrs <[email protected]>
It's a common pattern in tacd codebase to collect all Topics in a struct to make them available to e.g. the UI code. These fields are not used, but should nevertheless be stored in the respective struct to keep the common pattern. Signed-off-by: Leonard Göhrs <[email protected]>
It's a common pattern in tacd codebase to collect all Topics in a struct to make them available to e.g. the UI code. This field is not used, but should nevertheless be stored in the respective struct to keep the common pattern. Signed-off-by: Leonard Göhrs <[email protected]>
It's a common pattern in tacd codebase to collect all Topics in a struct to make them available to e.g. the UI code. These fields are not used, but should nevertheless be stored in the respective struct to keep the common pattern. Signed-off-by: Leonard Göhrs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that our CI once again runs without reporting any issues.