Skip to content

ci: tacd-webui: use a fixed node version instead of latest #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

hnez
Copy link
Member

@hnez hnez commented Nov 18, 2024

The build sometimes breaks due to node updates. This would not be much of a problem if the fixes for these breakages did
not break our actual builds with the node versions used in Yocto.

Fix that by using a fixed node version - in this case the one from the Styhead release.

Also make sure the build works on Scarthgap as well.

This should fix the build issue we have seen in this scheduled run: https://github.com/linux-automation/tacd/actions/runs/11845302859

@hnez hnez marked this pull request as ready for review November 18, 2024 07:37
@hnez hnez requested a review from KarlK90 November 18, 2024 07:38
@hnez
Copy link
Member Author

hnez commented Nov 18, 2024

The failing cargo deny check is not caused by this PR and will be fixed by #84.

hnez added 2 commits January 6, 2025 07:54
The build sometimes breaks due to node updates.
This would not be much of a problem if the fixes for these breakages did
not break our actual builds with the node versions used in Yocto.

Fix that by using a fixed node version - in this case the one from the
Styhead release.

Signed-off-by: Leonard Göhrs <[email protected]>
We are currently on yocto scarthgap but will switch to styhead soon,
make sure both builds work.

Signed-off-by: Leonard Göhrs <[email protected]>
@hnez hnez merged commit 51641a8 into linux-automation:main Jan 6, 2025
16 checks passed
@hnez hnez deleted the node-version branch January 6, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants